Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix warnings about cmake_minimum_required(…) #1684

Merged
merged 1 commit into from
Oct 29, 2023
Merged

cmake: fix warnings about cmake_minimum_required(…) #1684

merged 1 commit into from
Oct 29, 2023

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Oct 28, 2023 •
edited by Frenzie
Loading 

CMake Warning (dev) at CMakeLists.txt:1 (project):
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.

This change is Reviewable

@benoit-pierre
cmake: fix warnings about cmake_minimum_required(…)
c2e5bbb 
```
CMake Warning (dev) at CMakeLists.txt:1 (project):
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.
```
@Frenzie Frenzie merged commit 11f8176 into koreader:master Oct 29, 2023
2 checks passed
@benoit-pierre benoit-pierre deleted the pr/fix_cmake_warnings branch October 29, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiLuJe NiLuJe NiLuJe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @NiLuJe @Frenzie